Bump msys2/setup-msys2 from 2.27.0 to 2.28.0#296
Merged
oscarbenjamin merged 6 commits intomainfrom Aug 29, 2025
Merged
Conversation
Bumps [msys2/setup-msys2](https://github.com/msys2/setup-msys2) from 2.27.0 to 2.28.0. - [Release notes](https://github.com/msys2/setup-msys2/releases) - [Changelog](https://github.com/msys2/setup-msys2/blob/main/CHANGELOG.md) - [Commits](msys2/setup-msys2@v2.27.0...v2.28.0) --- updated-dependencies: - dependency-name: msys2/setup-msys2 dependency-version: 2.28.0 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>
dependabot
bot
added
dependencies
Contributor
Author
|
OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting If you change your mind, just re-open this PR and I'll resolve any conflicts on it. |
|
It's fixed in the development version of the GMP, see msys2/MSYS2-packages#5499. |
Collaborator
|
Thanks. Let's see if the patch works here. |
|
I think you miss autoreconf run. |
Collaborator
|
The patch does not seem to work... |
| echo -------------------------------------------- | ||
| patch -N -Z < ../../../bin/patch-C23.diff | ||
| autoreconf | ||
| fi |
|
Yes. You can take look on my patch for gmpy.
…On Fri, Aug 29, 2025, 15:39 Oscar Benjamin ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In bin/build_dependencies_unix.sh
<#296 (comment)>
:
> @@ -164,6 +170,20 @@ if [ $USE_GMP = "gmp" ]; then
echo --------------------------------------------
patch -N -Z -p0 < ../../../bin/patch-arm64.diff
fi
+ #
+ # msys2/MSYS2-packages#5499
+ #
+ # This patch needed for GMP 6.3.0 building with msys2 or probably just
+ # newer gcc versions.
+ #
+ if [ $PATCH_GMP_C23 = "yes" ]; then
+ echo
+ echo --------------------------------------------
+ echo " patching GMP"
+ echo --------------------------------------------
+ patch -N -Z < ../../../bin/patch-C23.diff
+ autoreconf
+ fi
Like this?
—
Reply to this email directly, view it on GitHub
<#296 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAQOKGHXL7WEJB3XTM2FEXL3QBCZTAVCNFSM6AAAAACASDQBEWVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZTCNRYGU4TAMRVG4>
.
You are receiving this because you commented.Message ID:
***@***.***>
|
Collaborator
|
Looks like it is working now. Thanks! |
dependabot
bot
deleted the
dependabot/github_actions/msys2/setup-msys2-2.28.0
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bumps msys2/setup-msys2 from 2.27.0 to 2.28.0.
Release notes
Sourced from msys2/setup-msys2's releases.
Changelog
Sourced from msys2/setup-msys2's changelog.
Commits
40677d3v2.28.0 8808d186603421ac8e3e5b5f489b4629d5e9fe2dYou can trigger a rebase of this PR by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot mergewill merge this PR after your CI passes on it@dependabot squash and mergewill squash and merge this PR after your CI passes on it@dependabot cancel mergewill cancel a previously requested merge and block automerging@dependabot reopenwill reopen this PR if it is closed@dependabot closewill close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)